Bug 2044496

Summary: Unable to create hardware events subscription - failed to add finalizers
Product: OpenShift Container Platform Reporter: Ori Michaeli <omichael>
Component: Bare Metal Hardware ProvisioningAssignee: Honza Pokorny <hpokorny>
Bare Metal Hardware Provisioning sub component: baremetal-operator QA Contact: Ori Michaeli <omichael>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: omichael, rpittau, yliu1
Version: 4.10Keywords: Triaged
Target Milestone: ---   
Target Release: 4.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-03-10 16:42:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ori Michaeli 2022-01-24 17:12:13 UTC 
Description of problem:

Creation of subscription looks good but when checking the BMC no subscription were created.

Output of metal3 pod logs:
...

"level":"error","ts":1643035823.766456,"logger":"controller.bmceventsubscription","msg":"Reconciler error","reconciler group":"metal3.io","reconciler kind":"BMCEventSubscription","name":"sub-01","namespace":"openshift-machine-api","error":"failed add finalizer: failed to add finalizer: admission webhook \"bmceventsubscription.metal3.io\" denied the request: subscriptions cannot be updated, please recreate it"

...
Version-Release number of selected component (if applicable):

4.10.0-0.nightly-2022-01-22-102609
How reproducible:


Steps to Reproduce:
1. Create a new HW events subscription.
2. Check that a subscription were created through the BMC API

Actual results:
Subscription creation failed.

Expected results:
Subscription creation succeeded.

Additional info:
Comment 1 Honza Pokorny 2022-01-24 17:35:43 UTC 
This is caused by an overzealous update validator webhook.  A fix is already proposed upstream:

https://github.com/metal3-io/baremetal-operator/pull/1077
Comment 8 Ori Michaeli 2022-02-03 21:52:34 UTC 
Verified with 4.10.0-0.nightly-2022-02-02-220834
Comment 10 errata-xmlrpc 2022-03-10 16:42:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056