Bug 1937085 - RHV UPI inventory playbook missing guarantee_memory
Summary: RHV UPI inventory playbook missing guarantee_memory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Installer
Version: 4.6
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.10.0
Assignee: Guilherme Santos
QA Contact: Guilherme Santos
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-03-09 18:58 UTC by Guilherme Santos
Modified: 2022-03-12 04:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-03-12 04:34:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift installer pull 5222 0 None Merged ovirt: update of upi playbook files 2021-10-12 12:30:32 UTC
Red Hat Product Errata RHSA-2022:0056 0 None None None 2022-03-12 04:35:19 UTC

Description Guilherme Santos 2021-03-09 18:58:39 UTC
Version:

$ openshift-install version
4.6

Platform:
ovirt/rhv

Please specify:
* UPI (semi-manual installation on customized infrastructure)

What happened?

When you use the UPI Ansible playbooks, it's provided a sample inventory.yaml file with some pre-settle variables, such as memory, however it doesn't have the variable guarantee_memory also pre-settle. 
This can be very misleading as guarantee_memory doesn't update automatically when deploying a vm using API/SDK/Ansible (in the same way it does when using the UI), resulting in the overcommit of the memory and a possible failure in the installation. So I think the inventory.yaml file should be updated with guarantee_memory varilabe and the create_template_vms.yaml playbook also should be update it removing guarantee_memory input on the task  so it does not break the run when deploying the template.

What did you expect to happen?

guarantee_memory variable set with a default value like memory  

How to reproduce it (as minimally and precisely as possible)?


Anything else we need to know?

Comment 1 Guilherme Santos 2021-03-09 19:04:20 UTC
typos: 
s/create-template-vms.yml/create-templates-and-vms.yml/g

(...) removing **template_memory_guaranteed** input on the task **Create templates** so it does not break the run when deploying the template.

Comment 2 Gal Zaidman 2021-03-30 15:12:06 UTC
due to capacity constraints we will be revisiting this bug in the upcoming sprint

Comment 6 Janos Bonic 2021-07-01 11:19:05 UTC
Gui, what's the status on this please?

Comment 14 Guilherme Santos 2021-11-04 11:07:28 UTC
Verified. UPI playbooks working and setting guarantee memory by default

Comment 18 errata-xmlrpc 2022-03-12 04:34:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.10.3 security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0056


Note You need to log in before you can comment on or make changes to this bug.