Bug 2047870 - Prevent redundant queries of BIOS settings in HostFirmwareController
Summary: Prevent redundant queries of BIOS settings in HostFirmwareController
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Bare Metal Hardware Provisioning
Version: 4.10
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: Bob Fournier
QA Contact: Lubov
URL:
Whiteboard:
Depends On:
Blocks: 2061794
TreeView+ depends on / blocked
 
Reported: 2022-01-28 18:41 UTC by Bob Fournier
Modified: 2022-08-23 19:39 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 2061794 (view as bug list)
Environment:
Last Closed: 2022-08-23 19:39:39 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github metal3-io baremetal-operator pull 1080 0 None Merged Only update the HFS status on changes 2022-03-08 15:35:01 UTC
Github openshift baremetal-operator pull 213 0 None open Merge upstream 2022-03-14 12:45:36 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-23 19:39:57 UTC

Description Bob Fournier 2022-01-28 18:41:08 UTC
Description of problem:

Currently the BMO reads the BIOS config settings from Ironic in the HSF controller reconciler and updates the status in the resource along with the LastUpdated flag. Once the resource is updated it will cause the reconciler to run again (although not a 2nd time because the LastUpdated flag will be the same).

This should be avoided by comparing the new settings to the old settings and old saving and updating the LastUpdated flag when they are different.

Comment 5 Lubov 2022-03-29 08:06:11 UTC
verified on 4.11.0-0.nightly-2022-03-27-140854. On our HP setup I see it happens every 5 min

Comment 7 errata-xmlrpc 2022-08-23 19:39:39 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.