Bug 2092579 - Don't retry pod deletion if objects are not existing
Summary: Don't retry pod deletion if objects are not existing
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.11
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: ffernand
QA Contact: Anurag saxena
URL:
Whiteboard:
: 2098587 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-06-01 20:21 UTC by ffernand
Modified: 2022-09-13 17:22 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 11:15:48 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift ovn-kubernetes pull 1123 0 None open [release 4.11] Bug 2092579: pods: deleteLogicalPort should not fail if port is already deleted 2022-06-13 17:15:59 UTC
Github ovn-org ovn-kubernetes issues 2973 0 None closed Don't retry deletion if objects are not existing 2022-06-01 20:21:54 UTC
Github ovn-org ovn-kubernetes pull 2974 0 None Merged pods: deleteLogicalPort should not fail if port is already deleted 2022-06-01 20:23:34 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 11:16:04 UTC

Description ffernand 2022-06-01 20:21:54 UTC 
This is a clone of upstream issue :

https://github.com/ovn-org/ovn-kubernetes/issues/2973

No need to retry deletion if pod's annotation isn't there. In this particular case, pod was created ; but before it was scheduled it got deleted, so it never had any LSP or annotation to begin with, deleteLogicalPort need not be strict with it.

Caught this in our CI:

[22:24](https://coreos.slack.com/archives/D027VSEKMAB/p1652127852674979)
or there must be “setting annotation ns/podname” message for this pod when it was created….
[22:24](https://coreos.slack.com/archives/D027VSEKMAB/p1652127864446549)
which should show the annotation on the pod
22:24
[Flavio Fernandes](https://app.slack.com/team/U027T1SK6AE) it is actually a bunch of pods
I0505 06:04:56.918812       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-bthk9
I0505 06:04:56.918830       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-bthk9, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-bthk9: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-bthk9: could not find OVN pod annotation in map[]
I0505 06:04:56.918839       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-8vtg4: retry object setup
I0505 06:04:56.918845       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-8vtg4
I0505 06:04:56.918850       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-8vtg4
I0505 06:04:56.918856       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-8vtg4, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-8vtg4: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-8vtg4: could not find OVN pod annotation in map[]
I0505 06:04:56.918860       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-spgbj: retry object setup
I0505 06:04:56.918864       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-spgbj
I0505 06:04:56.918868       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-spgbj
I0505 06:04:56.918874       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-spgbj, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-spgbj: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-spgbj: could not find OVN pod annotation in map[]
I0505 06:04:56.918878       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-b5mxc: retry object setup
I0505 06:04:56.918882       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-b5mxc
I0505 06:04:56.918886       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-b5mxc
I0505 06:04:56.918893       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-b5mxc, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-b5mxc: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-b5mxc: could not find OVN pod annotation in map[]
I0505 06:04:56.918897       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-cxx4w: retry object setup
I0505 06:04:56.918901       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-cxx4w
I0505 06:04:56.918905       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-cxx4w
I0505 06:04:56.918910       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-cxx4w, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-cxx4w: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-cxx4w: could not find OVN pod annotation in map[]
I0505 06:04:56.918913       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-r6mhj: retry object setup
I0505 06:04:56.918917       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-r6mhj
I0505 06:04:56.918920       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-r6mhj
I0505 06:04:56.918926       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-r6mhj, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-r6mhj: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-r6mhj: could not find OVN pod annotation in map[]
I0505 06:04:56.918930       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-nwqzc: retry object setup
I0505 06:04:56.918934       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-nwqzc
I0505 06:04:56.918938       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-nwqzc
I0505 06:04:56.918944       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-nwqzc, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-nwqzc: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-nwqzc: could not find OVN pod annotation in map[]
I0505 06:04:56.918948       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-6vfcv: retry object setup
I0505 06:04:56.918952       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-6vfcv
I0505 06:04:56.918955       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-6vfcv
I0505 06:04:56.918963       1 obj_retry.go:834] *v1.Pod retry delete failed for e2e-gc-9481/simpletest.rc-6vfcv, will try again later: deleteLogicalPort failed for pod e2e-gc-9481_simpletest.rc-6vfcv: unable to unmarshal pod annocations for pod e2e-gc-9481/simpletest.rc-6vfcv: could not find OVN pod annotation in map[]
I0505 06:04:56.918968       1 obj_retry.go:824] *v1.Pod e2e-gc-9481/simpletest.rc-9nkkx: retry object setup
I0505 06:04:56.918973       1 obj_retry.go:828] *v1.Pod retry: removing old object for e2e-gc-9481/simpletest.rc-9nkkx
I0505 06:04:56.918977       1 pods.go:98] Deleting pod: e2e-gc-9481/simpletest.rc-9nkkx
Comment 3 Miguel Duarte Barroso 2022-06-22 08:18:10 UTC 
*** Bug 2098587 has been marked as a duplicate of this bug. ***
Comment 5 errata-xmlrpc 2022-08-10 11:15:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069
Note You need to log in before you can comment on or make changes to this bug.